Merged
Conversation
…consistency - Add .nvmrc pinning to Node 22 for nvm users - Add .npmrc with engine-strict=true to reject wrong Node versions - Add @types/node override (^22.0.0) preventing transitive v25 resolution - Add Renovate allowedVersions (<23.0.0) for @types/node - Dedupe lockfile to remove @types/node@25 pollution Closes finos#2123
rocketstack-matt
force-pushed
the
chore/enforce-node-22-types
branch
from
e24a1be to
fa3da7e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent Node-version drift (and resulting lockfile/type inconsistencies) by enforcing Node 22 usage across installs/updates, constraining @types/node to v22, and regenerating the root lockfile to remove Node 25 pollution.
Changes:
- Add
.nvmrcand.npmrc(engine-strict=true) to steer/enforce Node version usage during installs. - Constrain
@types/nodeto Node 22 via rootpackage.json#overridesand a RenovateallowedVersionsrule. - Regenerate
package-lock.jsonto dedupe and remove hoisted@types/node@25, plus associated dependency tree churn; document the policy inAGENTS.md.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
.npmrc |
Enables engine-strict enforcement during npm installs. |
.nvmrc |
Adds an nvm pin intended to keep local Node aligned with CI. |
package.json |
Adds a root override to force @types/node to v22. |
renovate.json |
Prevents Renovate from proposing @types/node v23+ updates. |
package-lock.json |
Dedupes/updates dependency graph to remove Node 25 / types drift. |
AGENTS.md |
Documents Node 22 requirements and rationale for contributors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rocketstack-matt
force-pushed
the
chore/enforce-node-22-types
branch
from
46233fa to
43f0a57
Compare
rocketstack-matt
force-pushed
the
chore/enforce-node-22-types
branch
from
43f0a57 to
2e19b46
Compare
…lm-models to Node 22 types
rocketstack-matt
force-pushed
the
chore/enforce-node-22-types
branch
from
61ae50e to
e5c091b
Compare
markscott-ms
approved these changes
Feb 9, 2026
Contributor
markscott-ms
left a comment
markscott-ms
left a comment
There was a problem hiding this comment.
Makes sense. Node 20 is EOL in a couple of months.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2123
Type of Change
Affected Components
cli/)shared/)calm-widgets/)calm-hub/)calm-hub-ui/)docs/)calm-plugins/vscode/)Commit Message Format ✅
Testing
Checklist